rdblue commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022064188
########## python/pyiceberg/expressions/__init__.py: ########## @@ -111,7 +140,16 @@ class Reference(UnboundTerm[T]): name: str - def bind(self, schema: Schema, case_sensitive: bool = True) -> BoundReference[T]: + def __init__(self, name: str): + self.name = name + + def __repr__(self): + return f"Reference(name={repr(self.name)})" + + def __eq__(self, other): + return self.name == other.name if isinstance(other, Reference) else False + + def bind(self, schema: Schema, case_sensitive: bool = True) -> BoundReference: Review Comment: This should return a typed bound reference, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org