rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1021982246
##########
python/pyiceberg/expressions/__init__.py:
##########
@@ -90,16 +110,25 @@ def eval(self, struct: StructProtocol) -> T:
"""
return self.accessor.get(struct)
- def ref(self) -> BoundReference[T]:
+ def __eq__(self, other):
+ return self.field == other.field if isinstance(other, BoundReference)
else False
+
+ def __repr__(self) -> str:
+ return f"BoundReference(field={repr(self.field)},
accessor={repr(self.accessor)})"
+
+ def ref(self) -> BoundReference:
return self
-class UnboundTerm(Term[T], Unbound[BoundTerm[T]], ABC):
+class UnboundTerm(Term[Any], Unbound, ABC):
Review Comment:
Can we remove the type since it is unknown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
