rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1023269577
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -356,18 +326,26 @@ def _(self, type_var: DecimalType) -> Literal[Decimal]:
return DecimalLiteral(Decimal(self.value).quantize(Decimal((0, (1,),
-type_var.scale)), rounding=ROUND_HALF_UP))
-class DateLiteral(Literal[int]):
- def __init__(self, value: int):
- super().__init__(value, int)
+class DateLiteral(Literal[date]):
+ def __init__(self, value: date):
+ super().__init__(value, date)
Review Comment:
Sorry, I'm not sure when this changed, but I don't think that we want to
store a date in a `DateLiteral`. We want to normalize that to the standard
representation, days from unix epoch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
