Fokko commented on code in PR #6139: URL: https://github.com/apache/iceberg/pull/6139#discussion_r1020969932
########## python/tests/expressions/test_expressions.py: ########## @@ -365,7 +344,7 @@ def test_bound_greater_than_or_equal_invert(table_schema_simple: Schema): def test_bound_greater_than_invert(table_schema_simple: Schema): - bound = BoundGreaterThan( + bound = BoundGreaterThan[str]( Review Comment: If we want to fix this, we need to go one step further. `table_schema_simple.find_field` returns a `NestedField` that doesn't carry any type information. Then we should annotate all the primitives types with the Python types which is easy. The `ListType`, and `MapType` with the types of their respective element, key, and value. The most tricky one is the `StructType`, which has a tuple of different types. For the tuple in the `StructType` we could leverage the `TypeVarTuple`, but that has been introduced in 3.11, which is just out: https://peps.python.org/pep-0646/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
