rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1017240440


##########
python/tests/expressions/test_expressions.py:
##########
@@ -272,6 +235,22 @@ def test_in_empty():
     assert In(Reference("foo"), ()) == AlwaysFalse()
 
 
+def test_in_set():
+    assert In(Reference("foo"), {"a", "bc", "def"}).literals == 
{StringLiteral("a"), StringLiteral("bc"), StringLiteral("def")}
+
+
+def test_in_sets():
+    assert In(Reference("foo"), {"a"}, {"bc", "def"}).literals == 
{StringLiteral("a"), StringLiteral("bc"), StringLiteral("def")}

Review Comment:
   I'd rather not support this because it isn't clear that the sets get merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to