nastra commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1021905311
##########
core/src/main/java/org/apache/iceberg/rest/RESTClient.java:
##########
@@ -54,11 +54,19 @@ default <T extends RESTResponse> T delete(
<T extends RESTResponse> T delete(
String path,
- Map<String, String> queryParams,
Class<T> responseType,
Map<String, String> headers,
Consumer<ErrorResponse> errorHandler);
+ default <T extends RESTResponse> T delete(
+ String path,
+ Map<String, String> queryParams,
Review Comment:
@danielcweeks suggested to throw an exception if `queryParams` are used so
that we don't just silently drop them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
