rdblue commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1016042277
##########
python/tests/expressions/test_visitors.py:
##########
@@ -827,24 +834,23 @@ def _to_manifest_file(*partitions: PartitionFieldSummary)
-> ManifestFile:
)
-def _create_manifest_evaluator(bound_expr: BoundPredicate) ->
_ManifestEvalVisitor:
- """For testing. Creates a bogus evaluator, and then replaces the
expression"""
- evaluator = _ManifestEvalVisitor(
- Schema(NestedField(1, "id", LongType())),
EqualTo(term=Reference("id"), literal=literal("foo"))
- )
- evaluator.partition_filter = bound_expr
- return evaluator
+@pytest.fixture
+def string_schema() -> Schema:
Review Comment:
You may actually want to just base the tests here on the Java version, which
has pretty through tests and reuses the manifest metadata:
https://github.com/apache/iceberg/blob/master/api/src/test/java/org/apache/iceberg/expressions/TestInclusiveManifestEvaluator.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
