rdblue commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1015879735
##########
python/tests/expressions/test_visitors.py:
##########
@@ -836,15 +843,23 @@ def _create_manifest_evaluator(bound_expr:
BoundPredicate) -> _ManifestEvalVisit
return evaluator
-def test_manifest_evaluator_less_than_no_overlap():
- expr = BoundLessThan(
- term=BoundReference(
- field=NestedField(field_id=1, name="foo", field_type=StringType(),
required=False),
- accessor=Accessor(position=0, inner=None),
- ),
- literal=StringLiteral("c"),
- )
+@pytest.fixture
+def string_schema() -> Schema:
+ return Schema(NestedField(field_id=1, name="col_str",
field_type=StringType(), required=False))
+
+
+@pytest.fixture
+def double_schema() -> Schema:
+ return Schema(NestedField(field_id=1, name="col_double",
field_type=DoubleType(), required=False))
+
+
+@pytest.fixture
+def long_schema() -> Schema:
+ return Schema(NestedField(field_id=1, name="col_long",
field_type=LongType(), required=False))
+
+def test_manifest_evaluator_less_than_no_overlap(string_schema: Schema):
Review Comment:
What does "no overlap" mean? To me it seems backwards in these tests:
```
----a----b----c---->
<-------------c # filter expression
a----b # value range
^^^^ # overlap
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
