rdblue commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1017244665
##########
python/tests/expressions/test_visitors.py:
##########
@@ -1039,36 +985,37 @@ def test_manifest_evaluator_equal_overlap():
)
],
)
-
- assert _create_manifest_evaluator(expr).eval(manifest)
+ assert _ManifestEvalVisitor(string_schema, expr).eval(manifest)
-def test_manifest_evaluator_equal_all_null():
- expr = BoundEqualTo(
- term=BoundReference(
- field=NestedField(field_id=1, name="foo", field_type=StringType(),
required=False),
- accessor=Accessor(position=0, inner=None),
- ),
- literal=StringLiteral("a"),
+def test_manifest_evaluator_equal_on_bound_with_upper_bound(string_schema:
Schema):
Review Comment:
With all of the Java tests copied over, do we need the original tests that
were in this suite? The Java ones should be thorough enough that we can just
remove these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
