Fokko commented on code in PR #6140:
URL: https://github.com/apache/iceberg/pull/6140#discussion_r1015799107
##########
python/tests/expressions/test_visitors.py:
##########
@@ -853,19 +868,11 @@ def test_manifest_evaluator_less_than_no_overlap():
upper_bound=_to_byte_buffer(StringType(), "b"),
)
)
-
- assert _create_manifest_evaluator(expr).eval(manifest)
+ assert _ManifestEvalVisitor(string_schema, expr).eval(manifest)
-def test_manifest_evaluator_less_than_overlap():
- expr = BoundLessThan(
- term=BoundReference(
- field=NestedField(field_id=1, name="foo", field_type=StringType(),
required=False),
- accessor=Accessor(position=0, inner=None),
- ),
- literal=StringLiteral("a"),
- )
-
+def test_manifest_evaluator_less_than_overlap(string_schema: Schema):
+ expr = LessThan[str](Reference("foo"), StringLiteral("a"))
Review Comment:
For these tests, I like that we explicitly use the `StringLiteral`, since we
know that we're picking the right `LiteralType`. If there would be a bug in the
literal selection process, all the tests would turn red instantly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
