kbendick commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r959219452
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java:
##########
@@ -87,6 +89,7 @@ public void endInput() throws IOException {
// remaining completed files to downstream before closing the writer so
that we won't miss any
// of them.
flush();
+ ended = true;
Review Comment:
Also, if it’s possible to add a test for this, that would be great! However,
the test seems admittedly like it might be flaky by nature, so if it’s not
consistently possible to test for this behavior or a spy can’t be used or
something, don’t worry too much about it. But looking into it would be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
