stevenzwu commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r960193250
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java:
##########
@@ -87,6 +89,7 @@ public void endInput() throws IOException {
// remaining completed files to downstream before closing the writer so
that we won't miss any
// of them.
flush();
+ ended = true;
Review Comment:
+1 for adding a unit test. I think it can be deterministic. take a look at
the `TestIcebergStreamWriter`. we can trigger the `endInput` first, then the
`prepareSnapshotPreBarrier` to simulate this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
