kbendick commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r959213199
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriter.java:
##########
@@ -87,6 +89,7 @@ public void endInput() throws IOException {
// remaining completed files to downstream before closing the writer so
that we won't miss any
// of them.
flush();
+ ended = true;
Review Comment:
Oh never mind I see: we’re calling create and instantiating a new writer
after the other places that call `flush`, but not this one. Arguably we don’t
need the variable then.
But we should consider cleaning up the above comment and adding information
about the `null` check being used as the guard here or where the check happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
