anoopj commented on code in PR #19006:
URL: https://github.com/apache/iceberg/pull/19006#discussion_r4609846810


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -195,6 +195,11 @@ public List<Snapshot> apply() {
 
   private TableMetadata internalApply() {
     this.base = ops.refresh();
+    ValidationException.check(
+        CleanupLevel.NONE == cleanupLevel || !hasRootManifestSnapshot(base),
+        "Cannot expire snapshots with file cleanup: table has a snapshot with 
a root manifest "

Review Comment:
   The current error message was faithful to the check we do. Changed it to the 
suggestion.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to