anoopj commented on code in PR #19006:
URL: https://github.com/apache/iceberg/pull/19006#discussion_r4594353745


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -195,6 +195,11 @@ public List<Snapshot> apply() {
 
   private TableMetadata internalApply() {
     this.base = ops.refresh();
+    ValidationException.check(

Review Comment:
   You are correct. I changed the check in this PR and also 
https://github.com/apache/iceberg/pull/19008 to be a bit more lenient rather 
than just rejecting v4. It has also the niceness that we don't need to tweak 
tests that use `V2_AND_ABOVE` because they just won't have a root manifest. 
   
   I can send a followup PR to loosen 
https://github.com/apache/iceberg/pull/18999 rather than make this PR stricter. 
Let me know what you prefer. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to