dramaticlly commented on code in PR #19006:
URL: https://github.com/apache/iceberg/pull/19006#discussion_r4606832869
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -195,6 +195,11 @@ public List<Snapshot> apply() {
private TableMetadata internalApply() {
this.base = ops.refresh();
+ ValidationException.check(
+ CleanupLevel.NONE == cleanupLevel || !hasRootManifestSnapshot(base),
Review Comment:
I dont tthink it has to be comprehenstive check here, but
https://github.com/apache/iceberg/blob/ecfdad338c7a9c60bda87765c49413f18aef0137/core/src/main/java/org/apache/iceberg/RemoveSnapshots.java#L180
if cleanExpiredMetadata is set to true it might bypass the cleanup level, but
I think it will still run into later check in `BaseSnapshot.cacheManifest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]