singhpk234 commented on code in PR #18878:
URL: https://github.com/apache/iceberg/pull/18878#discussion_r4601816178
##########
docs/docs/rest-catalog.md:
##########
@@ -90,7 +90,8 @@ at connection time through
| `rest.client.connections-per-route` | `100` | Maximum number of pooled
connections per route.
|
| `rest.client.connection-timeout-ms` | null | Timeout in milliseconds for
establishing a connection to the server. If not set, the HTTP client library
default is used.
|
| `rest.client.socket-timeout-ms` | null | Socket timeout in
milliseconds for awaiting data on a connection. If not set, the HTTP client
library default is used.
|
-| `rest.client.user-agent` | null | Custom `User-Agent` header
value to send with each request. If not set, the HTTP client library default is
used.
|
+| `rest.client.user-agent` | null | Replaces the whole
`User-Agent` header. If unset, the header is `iceberg-java/<version> (jvm <java
version>)`, after any tokens from `rest.client.user-agent.prefix`. Only visible
ASCII characters and spaces are allowed.
|
+| `rest.client.user-agent.prefix` | null | Client application's product
tokens, such as `Trino/438`, sent before the `iceberg-java` token in the
`User-Agent` header. Ignored if `rest.client.user-agent` is set. Only visible
ASCII characters and spaces are allowed.
|
Review Comment:
should we fail when both are set ? i see in the implementation we let one
config override the other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]