rahulsmahadev commented on code in PR #18878:
URL: https://github.com/apache/iceberg/pull/18878#discussion_r4593513096


##########
docs/docs/rest-catalog.md:
##########
@@ -90,7 +90,7 @@ at connection time through
 | `rest.client.connections-per-route` | `100`   | Maximum number of pooled 
connections per route.                                                          
                                                                                
                                                                                
                                           |
 | `rest.client.connection-timeout-ms` | null    | Timeout in milliseconds for 
establishing a connection to the server. If not set, the HTTP client library 
default is used.                                                                
                                                                                
                                           |
 | `rest.client.socket-timeout-ms`     | null    | Socket timeout in 
milliseconds for awaiting data on a connection. If not set, the HTTP client 
library default is used.                                                        
                                                                                
                                                      |
-| `rest.client.user-agent`            | null    | Custom `User-Agent` header 
value to send with each request. If not set, the HTTP client library default is 
used.                                                                           
                                                                                
                                         |
+| `rest.client.user-agent`            | null    | Client application's product 
tokens, such as `Trino/438`, sent before the `iceberg-java` token in the 
`User-Agent` header. If unset, the header is `iceberg-java/<version> (jvm <java 
version>)`.                                                                     
                                              |

Review Comment:
   Agreed, that's cleaner. `rest.client.user-agent` is a full override again, 
as it was before this PR, and the new `rest.client.user-agent.prefix` holds the 
caller's tokens. The override takes precedence if both are set. I updated the 
docs and the PR description to match.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to