rahulsmahadev opened a new pull request, #18878: URL: https://github.com/apache/iceberg/pull/18878
The REST catalog spec now recommends a standard User-Agent format (#17727). This makes `HTTPClient` follow it. - `HTTPClient` always sends `iceberg-java/<version> (jvm <java version>)`. Before, it sent the Apache HttpClient default unless `rest.client.user-agent` was set. - `rest.client.user-agent` now holds the client application's own product tokens, which are sent before the `iceberg-java` token, for example `Trino/438 iceberg-java/1.11.0 (jvm 17.0.9)`. Before, the property replaced the whole header. This keeps the library token in the header, as the spec recommends. - Spark, Flink and Kafka Connect will add their own tokens in a follow-up. Testing: `TestHTTPClient` covers the default header and the header with the property set. This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
