pvary commented on code in PR #18850:
URL: https://github.com/apache/iceberg/pull/18850#discussion_r4538350578
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/DataFileRewriteCommitter.java:
##########
@@ -161,7 +161,13 @@ public void processWatermark(Watermark mark) throws
Exception {
@Override
public void close() throws IOException {
if (commitService != null) {
- commitService.close();
+ try {
+ commitService.close();
+ } catch (Exception e) {
+ LOG.warn("Exception closing commit service for table {} task {}",
tableName, taskName, e);
+ } finally {
+ this.commitService = null;
Review Comment:
Is there anything in Flink which might want to used the commitService after
the close is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
