Guosmilesmile commented on PR #18850: URL: https://github.com/apache/iceberg/pull/18850#issuecomment-6734983449
@ebyhr Fixing only the watermark path is not enough. If the job is cancelled before MAX_WATERMARK arrives, processWatermark() is never called, and close() calls commitService.close() directly. This can also fail when cancellation interrupts awaitTermination. Therefore, both paths need to be fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
