ebyhr commented on PR #18850: URL: https://github.com/apache/iceberg/pull/18850#issuecomment-6734752217
This `finally` doesn't cover the case where `processWatermark` closes the service but skips `this.commitService = null` (e.g. `output.collect` throws). `close()` then throws "Cannot close already closed commit service". #18849 resets it in `processWatermark` and has a test for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
