Guosmilesmile commented on code in PR #18149:
URL: https://github.com/apache/iceberg/pull/18149#discussion_r4490099648
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergLookupJoinSql.java:
##########
@@ -171,6 +173,91 @@ void lookupJoinWithOptionsInTableDdl() throws Exception {
Row.of(3L, 3L, "carol", "guangzhou"));
}
+ @Test
+ void lookupJoinReloadsFullCacheFromNewSnapshot() throws Exception {
+ Table dimTable =
+ CATALOG_EXTENSION.catalog().createTable(TestFixtures.TABLE_IDENTIFIER,
DIM_SCHEMA);
+ GenericAppenderHelper helper =
+ new GenericAppenderHelper(dimTable, FileFormat.PARQUET,
temporaryFolder);
+ helper.appendToTable(
+ helper.writeFile(
+ Lists.newArrayList(
+ dimRecord(1L, "alice", "beijing"),
+ dimRecord(2L, "bob", "shanghai"),
+ dimRecord(3L, "carol", "guangzhou"))));
+
+ TableEnvironment streamEnv = getStreamingTableEnv();
+ // Two probe rows per second, so the last probe row is joined seconds
after the cache is
+ // loaded, which leaves the reload time to pick up the row appended below.
+ createOrdersTable(streamEnv, "orders_reload_new_snapshot", 10, ",\n
'rows-per-second' = '2'");
Review Comment:
Switched to a deadline: the probe is now bounded (150 rows at 50 rows/s)
with randomized keys, and the test drains until it sees the new row or the
probe ends, with a 10s backstop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
