Guosmilesmile commented on code in PR #18149:
URL: https://github.com/apache/iceberg/pull/18149#discussion_r4494621532
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/source/lookup/IcebergFullCachingLookupFunction.java:
##########
@@ -152,6 +175,10 @@ public Collection<RowData> lookup(RowData keyRow) throws
IOException {
@Override
public void close() throws Exception {
+ if (reloadTrigger != null) {
Review Comment:
Yes, interrupting the operation does not actually stop an ongoing scan,
which can leave false signals. I added a `closed` flag to distinguish
shutdown-related events.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
