Guosmilesmile commented on code in PR #18149:
URL: https://github.com/apache/iceberg/pull/18149#discussion_r4494636078
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergLookupJoinSql.java:
##########
@@ -288,8 +395,35 @@ private void createDimTable(Record... records) throws
IOException {
helper.appendToTable(dataFile);
}
+ private static void createRepeatingOrdersTable(
+ TableEnvironment tableEnvironment, String tableName, int numberOfKeys) {
+ SqlHelpers.sql(
+ tableEnvironment,
+ "CREATE TEMPORARY TABLE %s (\n"
+ + " user_id BIGINT,\n"
+ + " proc_time AS PROCTIME()\n"
+ + ") WITH (\n"
+ + " 'connector' = 'datagen',\n"
+ + " 'number-of-rows' = '150',\n"
Review Comment:
The probe is unbounded now and the only bound is a 10s deadline, the success
path exits on the first reloaded row, so it costs nothing when it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
