Guosmilesmile commented on code in PR #18303:
URL: https://github.com/apache/iceberg/pull/18303#discussion_r4455387728
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommittable.java:
##########
@@ -26,8 +26,10 @@
/**
* The aggregated results of a single checkpoint which should be committed.
Containing the
- * serialized {@link DeltaManifests} files - which contains the commit data,
and the jobId,
- * operatorId, checkpointId triplet to identify the specific commit.
+ * serialized {@link DeltaManifests} files - which contains the commit data,
and the jobId, sinkId,
Review Comment:
Ok, add it in note.
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicCommitter.java:
##########
@@ -280,7 +285,8 @@ void testSkipsCommitRequestsForPreviousCheckpoints() throws
Exception {
TableKey tableKey = new TableKey(TABLE1, "branch");
DynamicWriteResultAggregator aggregator =
- new DynamicWriteResultAggregator(CATALOG_EXTENSION.catalogLoader(),
cacheMaximumSize);
+ new DynamicWriteResultAggregator(
+ CATALOG_EXTENSION.catalogLoader(), cacheMaximumSize, "sinkId");
Review Comment:
Good point. The aggregator only writes manifests, so its sinkId doesn't
matter. I used a constant for clarity.
I also updated two tests to use different sinkId and jobId values and verify
flink.sink-id. Other tests keep them the same since the distinction isn't
relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
