pvary commented on code in PR #18303:
URL: https://github.com/apache/iceberg/pull/18303#discussion_r4454478715
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommittable.java:
##########
@@ -26,8 +26,10 @@
/**
* The aggregated results of a single checkpoint which should be committed.
Containing the
- * serialized {@link DeltaManifests} files - which contains the commit data,
and the jobId,
- * operatorId, checkpointId triplet to identify the specific commit.
+ * serialized {@link DeltaManifests} files - which contains the commit data,
and the jobId, sinkId,
Review Comment:
Shall we document the sinkId in the md files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
