szehon-ho commented on code in PR #2710:
URL: https://github.com/apache/iceberg-rust/pull/2710#discussion_r4418837596
##########
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs:
##########
@@ -763,10 +763,10 @@ mod test {
)
.unwrap(),
) as ArrayRef;
- let col13 = Arc::new(arrow_array::LargeBinaryArray::from_opt_vec(vec![
- Some(b"one"),
- Some(b""),
- Some(b"zzzz"),
+ let col13 = Arc::new(arrow_array::BinaryArray::from_opt_vec(vec![
+ Some(b"one".as_slice()),
+ Some(b"".as_slice()),
+ Some(b"zzzz".as_slice()),
Review Comment:
it seems ok to me, its consistent with the other ones. can probably remove
it as another pr if its not necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
