szehon-ho commented on code in PR #2710:
URL: https://github.com/apache/iceberg-rust/pull/2710#discussion_r4418858737
##########
crates/iceberg/src/arrow/schema.rs:
##########
@@ -890,7 +890,8 @@ impl SchemaVisitor for ToArrowSchemaConverter {
.map(DataType::FixedSizeBinary)
.unwrap_or(DataType::LargeBinary),
)),
- PrimitiveType::Binary | PrimitiveType::Geometry(_) |
PrimitiveType::Geography(_) => {
+ PrimitiveType::Binary =>
Ok(ArrowSchemaOrFieldOrType::Type(DataType::Binary)),
Review Comment:
Please preserve `LargeBinaryArray` input support in the equality-delete
writer and add a regression test. Its projector now uses a `Binary` schema but
reuses the input arrays without casting, so previously accepted batches with
`LargeBinaryArray` equality columns fail `RecordBatch::try_new` with a type
mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
