Copilot commented on code in PR #2710:
URL: https://github.com/apache/iceberg-rust/pull/2710#discussion_r4418810535
##########
crates/iceberg/src/writer/base_writer/equality_delete_writer.rs:
##########
@@ -763,10 +763,10 @@ mod test {
)
.unwrap(),
) as ArrayRef;
- let col13 = Arc::new(arrow_array::LargeBinaryArray::from_opt_vec(vec![
- Some(b"one"),
- Some(b""),
- Some(b"zzzz"),
+ let col13 = Arc::new(arrow_array::BinaryArray::from_opt_vec(vec![
+ Some(b"one".as_slice()),
+ Some(b"".as_slice()),
+ Some(b"zzzz".as_slice()),
Review Comment:
Same as in `parquet_writer.rs`: `b\"...\".as_slice()` is unnecessary here.
Using `Some(b\"one\")` / `Some(b\"\")` / `Some(b\"zzzz\")` keeps the test data
clearer.
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -1377,11 +1377,11 @@ mod tests {
None,
Some("d"),
])) as ArrayRef;
- let col6 = Arc::new(arrow_array::LargeBinaryArray::from_opt_vec(vec![
- Some(b"one"),
+ let col6 = Arc::new(arrow_array::BinaryArray::from_opt_vec(vec![
+ Some(b"one".as_slice()),
None,
- Some(b""),
- Some(b"zzzz"),
+ Some(b"".as_slice()),
+ Some(b"zzzz".as_slice()),
])) as ArrayRef;
Review Comment:
`b\"...\".as_slice()` is redundant because `b\"...\"` already coerces to
`&[u8]` in this context. Consider simplifying these to `Some(b\"one\")`,
`Some(b\"\")`, etc. to improve readability and reduce noise in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
