sarthakuwar opened a new pull request, #4179: URL: https://github.com/apache/iceberg-python/pull/4179
# Rationale for this change `mkdocs/docs/configuration.md` documents `gcs.default-location`, but the code reads a different key: ```python # pyiceberg/io/__init__.py GCS_DEFAULT_LOCATION = "gcs.default-bucket-location" ``` Both `PyArrowFileIO` (`pyiceberg/io/pyarrow.py`, passed as `default_bucket_location`) and `FsspecFileIO` (`pyiceberg/io/fsspec.py`, passed as `default_location`) look up `gcs.default-bucket-location`. Anyone who sets the documented key gets no error, and the setting is silently ignored. While there, I added the missing `s3.ssl.ca-cert` row to the S3 table. It is read in `PyArrowFileIO._set_tls_ca_file_path` and needs pyarrow 21.0.0 or later (the code raises `ImportError` otherwise). It is not used by `FsspecFileIO`. ## Are these changes tested? Docs only. I checked both keys against the constants in `pyiceberg/io/__init__.py` and where they are read, and ran `markdownlint` (v0.45.0, the version in `.pre-commit-config.yaml`) and `codespell` on the file. Both pass. ## Are there any user-facing changes? Docs only. No code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
