anoopj commented on code in PR #18546:
URL: https://github.com/apache/iceberg/pull/18546#discussion_r4364335108
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -160,28 +173,29 @@ protected void validate(TableMetadata base, Snapshot
parent) {
}
}
+ Expression validationFilter = validationFilter();
+
if (validateNewDataFiles) {
- validateAddedDataFiles(base, startingSnapshotId,
dataConflictDetectionFilter(), parent);
+ validateAddedDataFiles(base, startingSnapshotId, validationFilter,
parent);
}
if (validateNewDeletes) {
if (rowFilter() != Expressions.alwaysFalse()) {
- Expression filter = conflictDetectionFilter != null ?
conflictDetectionFilter : rowFilter();
- validateNoNewDeleteFiles(base, startingSnapshotId, filter, parent);
- validateDeletedDataFiles(base, startingSnapshotId, filter, parent);
+ validateNoNewDeleteFiles(base, startingSnapshotId, validationFilter,
parent);
+ validateDeletedDataFiles(base, startingSnapshotId, validationFilter,
parent);
}
if (!deletedDataFiles.isEmpty()) {
validateNoNewDeletesForDataFiles(
- base, startingSnapshotId, conflictDetectionFilter,
deletedDataFiles, parent);
+ base, startingSnapshotId, validationFilter, deletedDataFiles,
parent);
Review Comment:
Yep, that is a great summary. This is a behavior change. It doesn't affect
Spark currently, but there could be external clients relying on this, and we
need a discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
