anoopj commented on code in PR #18546:
URL: https://github.com/apache/iceberg/pull/18546#discussion_r4299735015
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -61,6 +62,14 @@ protected String operation() {
@Override
public OverwriteFiles overwriteByRowFilter(Expression expr) {
+ Preconditions.checkState(
+ conflictDetectionFilter == null,
+ "Cannot overwrite by row filter when a conflict detection filter is
set: %s",
+ conflictDetectionFilter);
+ Preconditions.checkState(
+ deletedDataFiles.isEmpty(),
+ "Cannot overwrite by row filter when data files are deleted
explicitly");
+ this.rowFilterSet = true;
Review Comment:
The alternative was to compare the value of `rowFilter` being `alwaysFalse`
- explicit boolean looked like a better option to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
