adityaksolves commented on code in PR #18517:
URL: https://github.com/apache/iceberg/pull/18517#discussion_r4295008654
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -266,12 +279,14 @@ private CacheItem(
boolean tableExists,
Set<String> branches,
Map<Integer, Schema> tableSchemas,
+ int currentSchemaId,
Review Comment:
Makes sense, thanks. I’ll try storing the schemas pre-ordered (current
schema first, then the rest in ascending id order) so CacheItem doesn’t need
currentSchemaId. I’ll prototype it on Flink 1.20 first. @mxm let me know if
you’d prefer a different approach before I port it to 2.2 and 2.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
