mxm commented on code in PR #18517:
URL: https://github.com/apache/iceberg/pull/18517#discussion_r4295172870


##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java:
##########
@@ -266,12 +279,14 @@ private CacheItem(
         boolean tableExists,
         Set<String> branches,
         Map<Integer, Schema> tableSchemas,
+        int currentSchemaId,

Review Comment:
   +1 for storing the schemas sorted by schema id in the cache (newest first). 
I somehow thought they were stored that way using a LinkedHashMap, but they 
aren't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to