wgtmac commented on code in PR #1021:
URL: https://github.com/apache/iceberg-cpp/pull/1021#discussion_r4285069046
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -233,20 +233,18 @@ function(resolve_arrow_dependency)
"https://archive.apache.org/dist/thrift/0.22.0/thrift-0.22.0.tar.gz";)
endif()
- fetchcontent_declare(VendoredArrow
+ fetchcontent_declare(Arrow
Review Comment:
Its original name was Arrow. VendoredArrow was used temporarily to address a
bug in the Arrow repo and now we are just restoring its correct name. I don't
think FETCHCONTENT_SOURCE_DIR_VENDOREDARROW is a recommended use case and in
the README we just recommend to set installed Arrow to CMAKE_PREFIX_PATH.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
