shangxinli commented on code in PR #1021:
URL: https://github.com/apache/iceberg-cpp/pull/1021#discussion_r4284535468
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -233,20 +233,18 @@ function(resolve_arrow_dependency)
"https://archive.apache.org/dist/thrift/0.22.0/thrift-0.22.0.tar.gz";)
endif()
- fetchcontent_declare(VendoredArrow
+ fetchcontent_declare(Arrow
Review Comment:
This also renames the override variable
FETCHCONTENT_SOURCE_DIR_VENDOREDARROW to FETCHCONTENT_SOURCE_DIR_ARROW, so
anyone pointing it at a local Arrow checkout loses it silently. Worth a release
note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
