CTTY commented on code in PR #3265: URL: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4253381964
########## crates/iceberg/public-api.txt: ########## @@ -3238,25 +3238,33 @@ pub struct iceberg::transaction::AddColumn impl iceberg::transaction::AddColumn pub fn iceberg::transaction::AddColumn::optional(name: impl alloc::string::ToString, field_type: iceberg::spec::Type) -> Self pub fn iceberg::transaction::AddColumn::required(name: impl alloc::string::ToString, field_type: iceberg::spec::Type, initial_default: iceberg::spec::Literal) -> Self +impl core::clone::Clone for iceberg::transaction::AddColumn Review Comment: we can discuss here: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4253272622 closing this one ########## crates/iceberg/public-api.txt: ########## @@ -3238,25 +3238,33 @@ pub struct iceberg::transaction::AddColumn impl iceberg::transaction::AddColumn pub fn iceberg::transaction::AddColumn::optional(name: impl alloc::string::ToString, field_type: iceberg::spec::Type) -> Self pub fn iceberg::transaction::AddColumn::required(name: impl alloc::string::ToString, field_type: iceberg::spec::Type, initial_default: iceberg::spec::Literal) -> Self +impl core::clone::Clone for iceberg::transaction::AddColumn Review Comment: we can discuss here: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4253272622 resolving this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
