CTTY commented on code in PR #3265:
URL: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4253378250
##########
crates/iceberg/src/transaction/action.rs:
##########
@@ -159,14 +298,30 @@ mod tests {
let tx = Transaction::new(&table);
let updated_tx = action.apply(tx).unwrap();
- // There should be one action in the transaction now
+ // There should be one action entry in the transaction now
assert_eq!(updated_tx.actions.len(), 1);
(*updated_tx.actions[0])
- .downcast_ref::<TestAction>()
+ .downcast_ref::<ActionEntry<TestAction>>()
.expect("TestAction was not applied to Transaction!");
}
+ #[test]
+ fn test_transaction_clone_creates_fresh_entries() {
Review Comment:
Good point! I added `test_entry_retains_state_across_commits` and
`test_clone_with_new_state_resets_state` to actually exercise this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
