CTTY commented on code in PR #3265:
URL: https://github.com/apache/iceberg-rust/pull/3265#discussion_r4252768892
##########
crates/iceberg/src/transaction/mod.rs:
##########
@@ -84,10 +84,25 @@ pub use
crate::transaction::upgrade_format_version::UpgradeFormatVersionAction;
use crate::{Catalog, TableCommit, TableRequirement, TableUpdate};
/// Table transaction.
-#[derive(Clone)]
pub struct Transaction {
table: Table,
- actions: Vec<BoxedTransactionAction>,
+ actions: Vec<TransactionActionEntry>,
+}
+
+impl Clone for Transaction {
Review Comment:
Looks like we have discussed this in #1474 , `Clone` was added because it
allows consumer to retry transactions. Since now we are supporting retry within
transactions, I agree that Clone can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
