danielcweeks commented on PR #18378: URL: https://github.com/apache/iceberg/pull/18378#issuecomment-6070220569
@developer-rpai This seems like we're just adding complexity where it isn't necessary. I don't even understand why we think this needs to be asynchronous. The executor is only used by the cache to kick the `close()` on the auth session at time of eviction, but that's not implemented in all but the `RESTSigV4AuthSession` (I don't know that does anything unless you're using specific credential providers. Seems like the more straightforward fix here is to omit the executor unless it's explicitly provided. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
