developer-rpai opened a new pull request, #18378: URL: https://github.com/apache/iceberg/pull/18378
Each AuthSessionCache built a per-instance exiting worker pool, registering one JVM shutdown hook per OAuth2Manager. Every hook thread is constructed on the creating thread and copies its inheritable thread-locals, so on a long-lived Spark Connect driver this pinned closed Spark sessions -- catalogs, table caches and all -- for the life of the JVM. All instances now share a single daemon eviction thread created with inheritable thread-locals disabled, exposed only as a plain Executor so close() leaves it running. Fixes #18377. New tests verify the default executor is shared across instances, is not an ExecutorService, still accepts tasks after a sibling instance is closed, and that the worker thread inherits no thread-locals; the existing hit/miss and eviction tests still pass. Ran locally against minimal API stubs (Maven Central unreachable from this sandbox); please let CI run the full suite. --- **AI Disclosure** - Model: Muse Spark (Meta) - Platform/Tool: Muse (Meta AI agent), via parent-orchestrated subagent - Human Oversight: unreviewed - Prompt Summary: Implement the fix for apache/iceberg#18377 (AuthSessionCache per-instance shutdown-hook memory leak) with regression tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
