RussellSpitzer commented on code in PR #3363:
URL: https://github.com/apache/iceberg-rust/pull/3363#discussion_r4209238890
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -411,11 +410,13 @@ impl<'a> SnapshotProducer<'a> {
additional_properties,
};
- update_snapshot_summaries(
+ let mut summary = update_snapshot_summaries(
summary,
previous_snapshot.map(|s| s.summary()),
snapshot_produce_operation.operation() == Operation::Overwrite,
- )
+ )?;
+ set_iceberg_version(&mut summary.additional_properties);
Review Comment:
@mbutrovich Moved this into snapshot_summary so we don't have to have public
constants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
