RussellSpitzer commented on code in PR #3363:
URL: https://github.com/apache/iceberg-rust/pull/3363#discussion_r4209150795
##########
crates/iceberg/src/transaction/append.rs:
##########
@@ -764,6 +764,34 @@ mod tests {
);
}
+ #[tokio::test]
+ async fn test_snapshot_summary_records_writer_identity() {
+ let table = make_v2_minimal_table();
+ let tx = Transaction::new(&table);
+
+ let mut snapshot_properties = HashMap::new();
+ snapshot_properties.insert("key".to_string(), "val".to_string());
+
+ let action = tx
+ .fast_append()
+ .set_snapshot_properties(snapshot_properties);
+ let mut action_commit = Arc::new(action).commit(&table).await.unwrap();
+ let updates = action_commit.take_updates();
+
+ let new_snapshot = if let TableUpdate::AddSnapshot { snapshot } =
&updates[0] {
+ snapshot
+ } else {
+ unreachable!()
+ };
+ let props = &new_snapshot.summary().additional_properties;
+ let version = env!("CARGO_PKG_VERSION");
+
+ assert_eq!(
+ props.get("iceberg-version").unwrap(),
+ &format!("Apache Iceberg Rust {version}")
+ );
Review Comment:
Yes, I wrote that in the issue. At least I think the right thing to do is
always just use the version. I don't think a user should really be able to
override that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
