RussellSpitzer commented on code in PR #3363:
URL: https://github.com/apache/iceberg-rust/pull/3363#discussion_r4208619191
##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -34,6 +34,25 @@ use crate::table::Table;
use crate::transaction::ActionCommit;
use crate::{Error, ErrorKind, TableRequirement, TableUpdate};
+const ENGINE_NAME: &str = "iceberg-rust";
+const ENGINE_NAME_PROP: &str = "engine-name";
+const ENGINE_VERSION_PROP: &str = "engine-version";
+const ICEBERG_VERSION_PROP: &str = "iceberg-version";
+
+fn apply_writer_identity(properties: &mut HashMap<String, String>) {
+ let version = env!("CARGO_PKG_VERSION");
+ properties
+ .entry(ENGINE_NAME_PROP.to_string())
+ .or_insert_with(|| ENGINE_NAME.to_string());
+ properties
+ .entry(ENGINE_VERSION_PROP.to_string())
+ .or_insert_with(|| version.to_string());
Review Comment:
We could do this, we currently have disagreement between the
implementations. PyIceberg (https://github.com/apache/iceberg-python/pull/3441)
populates these, Java and Go do not. I'm fine with just dropping them though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
