mengna-lin commented on code in PR #18337:
URL: https://github.com/apache/iceberg/pull/18337#discussion_r4199189444


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -461,5 +461,9 @@ private TableProperties() {}
   public static final String ENCRYPTION_DEK_LENGTH = 
"encryption.data-key-length";
   public static final int ENCRYPTION_DEK_LENGTH_DEFAULT = 16;
 
+  public static final String ENCRYPTION_KEK_GENERATION_ENABLED =
+      "encryption.kek-generation-enabled";

Review Comment:
   @abhishekmauryaKsolves I have removed all key generation properties on 
Aliyun client side encryption in https://github.com/apache/iceberg/pull/18210. 
The scope of the pr does not cover key generation. so we are good. I will 
tackle it in a separate pr. Thanks for the reminder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to