abhishekmauryaKsolves commented on code in PR #18337:
URL: https://github.com/apache/iceberg/pull/18337#discussion_r4192659322
##########
core/src/main/java/org/apache/iceberg/encryption/StandardEncryptionManager.java:
##########
@@ -146,8 +160,17 @@ String keyEncryptionKeyID() {
}
// No unexpired key encryption keys; create one
- ByteBuffer unwrapped = newKey();
- ByteBuffer wrapped = kmsClient.wrapKey(unwrapped, tableKeyId);
+ ByteBuffer unwrapped;
+ ByteBuffer wrapped;
+ if (kekGenerationEnabled && kmsClient.supportsKeyGeneration()) {
Review Comment:
Done in fddd8e6 : it now throws an IllegalStateException when the property
is enabled but the client does not support key generation (the message names
the property and the client class). Test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
