abhishekmauryaKsolves commented on code in PR #18337:
URL: https://github.com/apache/iceberg/pull/18337#discussion_r4192304180
##########
core/src/main/java/org/apache/iceberg/encryption/EncryptionUtil.java:
##########
@@ -40,6 +40,7 @@ public class EncryptionUtil {
ImmutableSet.<String>builder()
.add(TableProperties.ENCRYPTION_TABLE_KEY)
.add(TableProperties.ENCRYPTION_DEK_LENGTH)
+ .add(TableProperties.ENCRYPTION_KEK_GENERATION_ENABLED)
Review Comment:
Thanks, agreed. I'll rename it to encryption.kms-key-generation-enabled
(constants ENCRYPTION_KMS_KEY_GENERATION_ENABLED / _DEFAULT) since the other
boolean table properties end in "enabled", and rename the related variables
accordingly. @mengna-lin FYI, this affects the property name used for the
Aliyun client in #18210.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
