pvary commented on code in PR #17900:
URL: https://github.com/apache/iceberg/pull/17900#discussion_r4183950616
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestRowDataConverter.java:
##########
@@ -85,6 +86,27 @@ void testPreservesRowKind() {
assertThat(convert(deleteRow, SCHEMA,
SCHEMA2).getRowKind()).isEqualTo(RowKind.DELETE);
}
+ @Test
+ void testVariantWithDataConversion() {
+ Schema sourceSchema =
+ new Schema(
+ Types.NestedField.optional(1, "id", Types.IntegerType.get()),
+ Types.NestedField.optional(2, "payload", Types.VariantType.get()));
+ Schema targetSchema =
+ new Schema(
+ Types.NestedField.optional(1, "id", Types.LongType.get()),
+ Types.NestedField.optional(2, "payload", Types.VariantType.get()));
+ assertThat(CompareSchemasVisitor.visit(sourceSchema, targetSchema))
Review Comment:
use the new version of `CompareSchemasVisitor.visit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
