fmorillo7694 commented on PR #17900: URL: https://github.com/apache/iceberg/pull/17900#issuecomment-5938473725
Thanks @pvary, this found a real gap. Variant to string already failed cleanly, but string to variant was silently skipped: `EvolveSchemaVisitor.updateColumn` only handled primitive targets, so the update committed with no change and the sink got a null resolved schema. It now fails with `Cannot change column type: payload: string -> variant`, matching the other direction, since Iceberg doesn't allow promoting a column to variant. I also added end-to-end tests in `TestDynamicIcebergSink` on a v3 table: writing variant data, adding a variant column through schema evolution, and both incompatible directions failing with a clear error. Updated in 2553881b0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
